Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6932: Use model binding instead of reading raw request data #8902

Closed
wants to merge 70 commits into from
Closed

Create rule S6932: Use model binding instead of reading raw request data #8902

wants to merge 70 commits into from

Conversation

martin-strecker-sonarsource
Copy link
Contributor

Fixes #8871

@martin-strecker-sonarsource
WIP: Add the RegisterSymbolStart wrapper
fc3844c
@martin-strecker-sonarsource
Clean up
5292552
@martin-strecker-sonarsource
Rename
749ffd6
@martin-strecker-sonarsource
More explanations
1af1a2e
@martin-strecker-sonarsource
Add RegisterCodeBlockStartActionCS and RegisterOperationAction
1ee7248
@martin-strecker-sonarsource
Add remaining register methods
c9fa25b
@martin-strecker-sonarsource
Clean up
808d845
@martin-strecker-sonarsource
Add explanation
837463d
@martin-strecker-sonarsource
Add tests for missing VB support
4455f4a
@martin-strecker-sonarsource
Add comments
d20e1a4
@martin-strecker-sonarsource
Formatting of comment
30364b4
@martin-strecker-sonarsource
Add the Sonar wrapping
7ffd749
@martin-strecker-sonarsource
Move TestDiagnosticAnalyzer
5c3e724
@martin-strecker-sonarsource
Fix comment
dede597
@martin-strecker-sonarsource
Cleanup
d78c9ad
@martin-strecker-sonarsource
Formattings
6cb5d33
@martin-strecker-sonarsource
Use property accessor instead of passing per ctor
6946d47
@martin-strecker-sonarsource
Move registerCodeBlockAction and registerCodeBlockStartActionCS to Sy…
b14acd4 
…mbolStartAnalysisContext
@martin-strecker-sonarsource
Move registerOperationAction
2ba613b
@martin-strecker-sonarsource
Move registerOperationBlockAction, registerOperationBlockStartAction,…
6c2b473 
… and registerSymbolEndAction
@martin-strecker-sonarsource
Move registerSyntaxNodeActionCS
d778bb8
@martin-strecker-sonarsource
Move comments
1a95c97
@martin-strecker-sonarsource
Make SymbolStartAnalysisContext a readonly struct
48dd732
@martin-strecker-sonarsource
Fix typo
1064cf6
@martin-strecker-sonarsource
Prepare tests
ac551d9
@martin-strecker-sonarsource
Code review.
56887c7
@martin-strecker-sonarsource
Remove unused using
f6fa0f3
@martin-strecker-sonarsource
Refactorings
439f729
@martin-strecker-sonarsource
Improve RegisterSymbolStartAction_SymbolStartProperties
844f5e5
@martin-strecker-sonarsource
Add registration tests.
6e4cdc6
@martin-strecker-sonarsource martin-strecker-sonarsource changed the base branch from master to Martin/ShimSymbolStartAction March 11, 2024 18:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
7 New issues
85.5% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Base automatically changed from Martin/ShimSymbolStartAction to master March 14, 2024 13:14
@martin-strecker-sonarsource
Copy link
Contributor Author

Replaced by #8930 (Rebase destroyed the branch)

@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioaversa antonioaversa Awaiting requested review from antonioaversa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule S6932: Use model binding instead of reading raw request data
1 participant
@martin-strecker-sonarsource