New rule S6962 for C#: You should pool HTTP connections with HttpClientFactory #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/S6962
branch
5 times, most recently
from
25a3cd2
to
abd6ab6
Compare
...ts/SonarAnalyzer.Test/TestCases/CloudNative/AzureFunctionsReuseClients.HttpClient.CSharp9.cs
Outdated
Show resolved
Hide resolved
gregory-paidis-sonarsource
requested changes
Apr 23, 2024
analyzers/tests/SonarAnalyzer.Test/Rules/AspNet/ControllersReuseClientTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/AspNet/ControllersReuseClientTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/ControllerReuseClient.CSharp12.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/ControllersReuseClient.Csharp8.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/ControllersReuseClient.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/ControllersReuseClient.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/ControllersReuseClient.cs
Outdated
Show resolved
Hide resolved
| || node.Parent.IsKind(SyntaxKind.ArrowExpressionClause)); | ||
|
|
||
| private static bool IsInConditionalCode(SyntaxNode node) => | ||
| node.Ancestors().Any(x => x.IsAnyKind(SyntaxKind.IfStatement, |
There was a problem hiding this comment.
You are doing this .Ancestors().Any(x => x.IsAnyKind(...) check 4-5 times, please extract it in CSharpSyntaxHelper:
public static bool HasAncestorOfKind(this SyntaxNode syntaxNode, params SyntaxKind[] syntaxKinds) =>
syntaxNode.Ancestors().Any(ancestor => ancestor.IsAnyKind(syntaxKinds));
There was a problem hiding this comment.
See also
There was a problem hiding this comment.
I'll do it in a separate cleanup PR to replace it everywhere in sonar-dotnet if that's ok.
I saw there are quite some occurrences.
EDIT: I just saw Martin's comment. For some reason, it was not loaded earlier. I'm checking that option now.
mary-georgiou-sonarsource
force-pushed
the
mary/S6962
branch
from
3877a4a
to
0af2b71
Compare
gregory-paidis-sonarsource
approved these changes
Apr 24, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/ControllersReuseClient.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/S6962
branch
from
55ba381
to
db469d3
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/S6962
branch
from
db469d3
to
c3d685e
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9091