Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S6966 FP: MongoDB Find can not be replaced by FindAsync #9326

Merged
merged 2 commits into from
May 27, 2024

Conversation

martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented May 23, 2024

Fixes #9265

This implementation follows option 2 of #9265 (comment)

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 23, 2024

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐳 💥

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit fd68d59 into master May 27, 2024
29 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the Martin/S6966_MongoDb branch May 27, 2024 12:06
@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Fix S6966 FP: Methods with different signatures should not trigger this rule. Fix S6966 FP: MongoDB Find can not be replaced by FindAsync May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix S6966 FP: MongoDB Find can not be replaced by FindAsync
2 participants