Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQ Plugin: Include cshtml files in caching #9556

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #8032

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource marked this pull request as ready for review July 30, 2024 16:43
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the title Include cshtml files SQ Plugin: Include cshtml files in caching Jul 31, 2024
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully understand these changes. I added some questions.

Copy link

sonarcloud bot commented Aug 2, 2024

Copy link

sonarcloud bot commented Aug 2, 2024

Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 13646f5 into master Aug 5, 2024
22 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the Zsolt/include-cshtml-files branch August 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the plugin to store the hash for the .cshtml files to enable incremental PR analysis
3 participants