SONARJAVA-5303 Replace logTester by ThreadLocalLogTester #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test check the logs based on the raw messages, so this is needed from the interface.
romainbrenguier
force-pushed
the
romain/flaky-windows-qa-test
branch
from
364f7f0 to
54be294
Compare
alban-auzeill
requested changes
Feb 7, 2025
| assertThat(logs).hasSize(1); | ||
| assertThat(logs.get(0)).isEqualTo(logMessage); | ||
|
|
||
| sonarComponents.fileCanBeSkipped(inputFile); | ||
| logs = filterOutAnalysisProgressLogMessages(logTester.getLogs(Level.INFO)); |
There was a problem hiding this comment.
org.sonar.java.TestUtils#filterOutAnalysisProgressLogMessages seems to not be used anymore, we should delete the method definition.
With this change we should avoid the logs being polluted by messages coming from different threads.
romainbrenguier
force-pushed
the
romain/flaky-windows-qa-test
branch
from
54be294 to
7aab386
Compare
|
alban-auzeill
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5303
With this change we should avoid the togs being polluted by messages coming from different threads.