Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANDOCKER-3 Update release pipeline to support new versioning #235

Conversation

csaba-feher-sonarsource
Copy link
Contributor

@csaba-feher-sonarsource csaba-feher-sonarsource commented May 16, 2024

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (SQSCANNER-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

@csaba-feher-sonarsource csaba-feher-sonarsource marked this pull request as draft May 16, 2024 12:02
@csaba-feher-sonarsource csaba-feher-sonarsource force-pushed the bugfix/cfeher/SCANDOCKER-3-update-release-pipeline-to-support-new-versioning branch from 8d4d12f to a3f93d0 Compare May 16, 2024 15:11
@csaba-feher-sonarsource csaba-feher-sonarsource changed the title bugfix/cfeher/scandocker 3 update release pipeline to support new versioning SCANDOCKER-3 Update release pipeline to support new versioning May 16, 2024
@csaba-feher-sonarsource csaba-feher-sonarsource marked this pull request as ready for review May 16, 2024 15:15
@csaba-feher-sonarsource
Copy link
Contributor Author

I have tested building a dummy release pipeline.

  • The push part was not tested
  • Also, this line, whether it gets the right value from the tag name, was not tested. I did not have a tag for that . full_image_tag=${{GitHub.event.release.tag_name }}

@henryju henryju force-pushed the bugfix/cfeher/SCANDOCKER-3-update-release-pipeline-to-support-new-versioning branch 2 times, most recently from f50091f to 76c9ed8 Compare May 17, 2024 14:51
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will test a release on Monday

@henryju henryju force-pushed the bugfix/cfeher/SCANDOCKER-3-update-release-pipeline-to-support-new-versioning branch from 76c9ed8 to bdf9915 Compare May 17, 2024 14:53
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@henryju henryju merged commit fa4d822 into master May 17, 2024
5 checks passed
@henryju henryju deleted the bugfix/cfeher/SCANDOCKER-3-update-release-pipeline-to-support-new-versioning branch May 17, 2024 15:05
@robross0606
Copy link

I'm confused by these changes. If this project is going to deviate from Sonar's regular versions, where and how do we log issues referencing the image version?

@henryju
Copy link
Member

henryju commented May 24, 2024

As for all Sonar products, our community entry point (for reporting issues, asking for help or feature requests) is our community forum. Then we will create appropriate issues in JIRA accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants