-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCANMAVEN-216 scanAll includes Java and Kotlin files if sonar.java.binaries
and sonar.java.libraries
are set
#222
Conversation
sonar.java.binaries
and sonar.java.libraries
is setsonar.java.binaries
and sonar.java.libraries
is set
9d0ec9c
to
ab51950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are on the right track but I think we can simplify a few things and make tests a little more explicit.
src/main/java/org/sonarsource/scanner/maven/bootstrap/MavenProjectConverter.java
Show resolved
Hide resolved
src/main/java/org/sonarsource/scanner/maven/bootstrap/ScannerBootstrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sonarsource/scanner/maven/bootstrap/SourceCollector.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sonarsource/scanner/maven/bootstrap/SourceCollector.java
Show resolved
Hide resolved
src/test/java/org/sonarsource/scanner/maven/SonarQubeMojoTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/sonarsource/scanner/maven/SonarQubeMojoTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/sonarsource/scanner/maven/bootstrap/SourceCollectorTest.java
Outdated
Show resolved
Hide resolved
sonar.java.binaries
and sonar.java.libraries
is setsonar.java.binaries
and sonar.java.libraries
are set
1c8208e
to
df150e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I left a couple of small improvements that could help
src/main/java/org/sonarsource/scanner/maven/bootstrap/ScannerBootstrapper.java
Outdated
Show resolved
Hide resolved
src/test/java/org/sonarsource/scanner/maven/bootstrap/ScannerBootstrapperTest.java
Outdated
Show resolved
Hide resolved
…naries and sonar.java.libraries is set
df150e4
to
1f198ae
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏿 Thanks for the changes!
No description provided.