SLE-924: Refactor standalone analysis ITs #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All interactions with notifactions and dialogs (shells) were not awaiting the shells to actually exist. This should now be fixed for all kind of shells that are contributed by us, for the shells contributed by RedDeer itself (e.g. project properties dialog) this is done on "their" side already.
|
sophio-japharidze-sonarsource
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLE-924
All interactions with notifications and dialogs (shells) were not awaiting the shells to actually exist. This should now be fixed for all shells contributed by us. For the shells contributed by RedDeer itself (e.g., the project properties dialog), this is done on "their" side already.
Because all the implementations of
WaitConditionare super big and mostly duplicated, I created a small task for the future (SLE-925) to de-duplicate it by creating a generic mother class. This is not part of this ticket, sprint, and release tho.