Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1603 Ensure UI thread does not call backend #1169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SLI-1603 Ensure UI thread does not call backend #1169

wants to merge 1 commit into from
+108 −61

Conversation

eray-felek-sonarsource
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource commented Sep 17, 2024 •
edited by jira bot
Loading

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 66d005f to f66b791 Compare September 18, 2024 12:21
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch 2 times, most recently from a98dfed to 410f1a9 Compare September 18, 2024 13:47
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 410f1a9 to 9215cee Compare September 18, 2024 14:53
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Sep 18, 2024 •
edited
Loading

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
6.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@eray-felek-sonarsource eray-felek-sonarsource marked this pull request as ready for review September 18, 2024 15:33
nquinquenel
nquinquenel reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok but I think we can go further into the optimization - I will contribute as well based on your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nquinquenel nquinquenel nquinquenel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eray-felek-sonarsource @nquinquenel