-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix muting of incorrect issues when bound to SonarCloud #5182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicking.
I'll take a closer look at UTs in parallel
src/SonarQube.Client/Api/V7_20/GetIssuesWithComponentRequest.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client/Api/V7_20/GetIssuesWithComponentRequest.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client/Api/V7_20/GetIssuesWithComponentRequest.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client/Api/V7_20/GetIssuesWithComponentRequest.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/DefaultConfiguration_Configure_Tests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesRequestTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Round for UTs
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesSonarCloudRequestTests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesSonarQubeRequestTests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesSonarQubeRequestTests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesRequestWrapperTests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesRequestWrapperTests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesRequestWrapperTests.cs
Outdated
Show resolved
Hide resolved
src/SonarQube.Client.Tests/Requests/Api/V7_20/GetIssuesRequestWrapperTests.cs
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #5181