Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1625 CaYC: Replace Moq with Nsubstitute #5836

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Nov 14, 2024

SLVS-1625

As part of CaYC, replace Moq with Nsubstitute in the touched test classes of this PR and clean up the test classes
Also reformat code and execute Resharper’s code cleanup both in the test classes and in the classes under test

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title SLVS-1625 CaYC: Replace Moq with Nsubstitute SLVS-1625 CaYC: Replace Moq with Nsubstitute Nov 14, 2024
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Education.UnitTests/EducationTests.cs Outdated Show resolved Hide resolved
src/Education.UnitTests/EducationTests.cs Outdated Show resolved Hide resolved
src/Education.UnitTests/EducationTests.cs Outdated Show resolved Hide resolved
src/Education.UnitTests/EducationTests.cs Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 15, 2024

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit 0ab977c into feature/severity-modes Nov 15, 2024
2 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/cayc-get-effective-issue-details branch November 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants