-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVS-1625 CaYC: Replace Moq with Nsubstitute #5836
Merged
gabriela-trutan-sonarsource
merged 6 commits into
feature/severity-modes
from
gt/cayc-get-effective-issue-details
Nov 15, 2024
Merged
SLVS-1625 CaYC: Replace Moq with Nsubstitute #5836
gabriela-trutan-sonarsource
merged 6 commits into
feature/severity-modes
from
gt/cayc-get-effective-issue-details
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hashicorp-vault-sonar-prod
bot
changed the title
SLVS-1625 CaYC: Replace Moq with Nsubstitute
SLVS-1625 CaYC: Replace Moq with Nsubstitute
Nov 14, 2024
vnaskos-sonar
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/Education.UnitTests/ErrorList/SonarErrorListEventProcessorTests.cs
Outdated
Show resolved
Hide resolved
src/Education.UnitTests/Rule/SLCoreRuleMetaDataProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Education/ErrorList/SonarErrorListEventProcessorProvider.cs
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
gabriela-trutan-sonarsource
merged commit Nov 15, 2024
0ab977c
into
feature/severity-modes
2 checks passed
gabriela-trutan-sonarsource
deleted the
gt/cayc-get-effective-issue-details
branch
November 15, 2024 13:04
vnaskos-sonar
pushed a commit
that referenced
this pull request
Nov 18, 2024
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1625
As part of CaYC, replace Moq with Nsubstitute in the touched test classes of this PR and clean up the test classes
Also reformat code and execute Resharper’s code cleanup both in the test classes and in the classes under test