SLVS-1638 Migrate CMake analysis to CFamily java plugin via SLCore #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnaskos-sonar
force-pushed
the
vn/cmake-migration
branch
from
3ef0a6e
to
aacbcb8
Compare
georgii-borovinskikh-sonarsource
approved these changes
Nov 27, 2024
| var compilationDatabasePath = compilationDatabaseLocator.Locate(); | ||
| if (compilationDatabasePath == null) | ||
| { | ||
| analysisStatusNotifier.AnalysisFailed(SLCoreStrings.CompilationDatabaseNotFound); |
There was a problem hiding this comment.
Hmm, this also means that the file will not be analyzed for secrets. Is that a desired behavior in this case?
There was a problem hiding this comment.
Hmm haven't thought about that
vnaskos-sonar
force-pushed
the
vn/cmake-migration
branch
from
a1ed1aa
to
469d024
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1638