Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports according to isort advice #15

Merged
merged 1 commit into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
python3 -m pip install mypy
- name: Get Python changed files
id: changed-py-files
uses: tj-actions/changed-files@v23
uses: tj-actions/changed-files@v44
with:
files: |
*.py
Expand Down
4 changes: 2 additions & 2 deletions cron_converter/cron.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from datetime import datetime, date
from datetime import date, datetime
from functools import total_ordering
from typing import Optional, List, Union
from typing import List, Optional, Union

from .sub_modules.part import Part
from .sub_modules.seeker import Seeker
Expand Down
7 changes: 3 additions & 4 deletions cron_converter/sub_modules/seeker.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
from datetime import datetime, timedelta, timezone
from dateutil import tz
import calendar
import copy
from typing import Optional
from datetime import datetime, timedelta
from typing import TYPE_CHECKING, List, Literal, Optional

from typing import TYPE_CHECKING, List, Literal
from dateutil import tz

if TYPE_CHECKING:
from cron import Cron
Expand Down
2 changes: 1 addition & 1 deletion cron_converter/sub_modules/utils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import datetime
from typing import Union, List
from typing import List, Union


def to_parts(d: Union[datetime.datetime, datetime.date]) -> List[Union[int, None]]:
Expand Down
8 changes: 6 additions & 2 deletions tests/integration/tests_cron.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import unittest

from cron_converter.cron import Cron
from fixtures.valid_crons import (
valid_crons_list,
valid_crons_string,
valid_crons_to_list,
)

from fixtures.valid_crons import valid_crons_string, valid_crons_to_list, valid_crons_list
from cron_converter.cron import Cron


class CronTest(unittest.TestCase):
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/tests_cron_invalid.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import unittest

from cron_converter.cron import Cron

from fixtures.invalid_crons import invalid_crons

from cron_converter.cron import Cron


class CronTestInvalid(unittest.TestCase):

Expand Down
9 changes: 4 additions & 5 deletions tests/integration/tests_cron_seeker.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import logging
import sys
import unittest
from datetime import datetime

from dateutil import tz
import logging
import sys
from fixtures.valid_schedule_date import valid_schedules, valid_schedules_timezone

from cron_converter.cron import Cron

from fixtures.valid_schedule_date import valid_schedules
from fixtures.valid_schedule_date import valid_schedules_timezone

logging.basicConfig(stream=sys.stdout, level=logging.DEBUG)
logger = logging.getLogger("TestLog")

Expand Down
4 changes: 2 additions & 2 deletions tests/integration/tests_cron_seeker_invalid.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import unittest
from datetime import datetime

from cron_converter.cron import Cron

from fixtures.invalid_schedule_date import invalid_schedules

from cron_converter.cron import Cron


class SeekerTestInvalid(unittest.TestCase):
def test_invalid_cron_date(self):
Expand Down
5 changes: 3 additions & 2 deletions tests/integration/tests_part.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import unittest
from cron_converter.sub_modules.part import Part
from cron_converter.sub_modules.units import units

from fixtures.valid_ranges import valid_ranges

from cron_converter.sub_modules.part import Part
from cron_converter.sub_modules.units import units


class PartTest(unittest.TestCase):

Expand Down
5 changes: 3 additions & 2 deletions tests/integration/tests_part_invalid.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import unittest
from cron_converter.sub_modules.part import Part
from cron_converter.sub_modules.units import units

from fixtures.invalid_ranges import invalid_ranges

from cron_converter.sub_modules.part import Part
from cron_converter.sub_modules.units import units


class PartTestInvalid(unittest.TestCase):

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/tests_cron.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import unittest
from datetime import datetime, date
from datetime import date, datetime

from cron_converter.cron import Cron

Expand Down
1 change: 1 addition & 0 deletions tests/unit/tests_part.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import unittest

from cron_converter.sub_modules.part import Part
from cron_converter.sub_modules.units import units

Expand Down
Loading