Sn32 develop June 2023 update #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Contrib into chibios-21.11.x
The USBHSv1 LLD for KINETIS was checking `epc->in_cb` and `epc->out_cb` to be non-NULL before calling `_usb_isr_invoke_in_cb()` and `_usb_isr_invoke_out_cb()`. This is not correct, because if the `USB_USE_WAIT` option is enabled, those ChibiOS macros do more than just invoking the callback - they also resume the thread that may be waiting for the transfer completion, and omitting the call results in that thread never getting resumed. The macros also perform the same pointer check internally before invoking the callback. Remove the unneeded checks to make the driver work properly with any APIs enabled by `USB_USE_WAIT`.
The USBHSv1 LLD for MIMXRT1062 was checking `epc->in_cb` and `epc->out_cb` to be non-NULL before calling `_usb_isr_invoke_in_cb()` and `_usb_isr_invoke_out_cb()`. This is not correct, because if the `USB_USE_WAIT` option is enabled, those ChibiOS macros do more than just invoking the callback - they also resume the thread that may be waiting for the transfer completion, and omitting the call results in that thread never getting resumed. The macros also perform the same pointer check internally before invoking the callback. Remove the unneeded checks to make the driver work properly with any APIs enabled by `USB_USE_WAIT`. Also remove the manipulation of `(usbp)->receiving` and `(usbp)->transmitting`, because the `_usb_isr_invoke_in_cb()` and `_usb_isr_invoke_out_cb()` macros handle that part too.
Fixes issue where GPTD_BFTM0 would point to BFTM1 when HT32_GPT_USE_BFTM0 and HT32_GPT_USE_BFTM1 are defined True (and leaving GPTD_BFTM1 unused). Additionally, this fixes undeclared variable warning when only HT32_GPT_USE_BFTM1 is defined True.
scsi_transport_transmit returns the length instead of the status message.
RP2040 i2c peripherals are numbered starting from zero, therefore the drivers shall follow the same numbering e.g. I2C0 uses the driver I2CD0. This commit fixes the current missmatch.
SAMD21: Adding Initial Support for SAMD21A
SN32 USB and timer hotfix
HT32: hal: Fix misleading indentation errors
[WB32] Added HSE status selection.
[RP2040] update i2c drivers to reflect peripheral number
For context, the page size of HT32F523xx is 512 bytes (see page 42 of HT32F52342/HT3252352 User Manual v1.30) and certain bootloaders jump to addresses that are not aligned to 1024 bytes (specified by common rules_code.ld). This commit updates the example ld scripts so that these bootloaders can correctly map the vector table and boot a ChibiOS application firmware.
This change introduces basic WDT HAL driver functionality (start, stop, reload) for HT32F165x and HT32F523xx.
HT32: Add low level driver for WDT
…or-align HT32: ld: Fix vector table alignment for HT32F523xx
The RP2040 ADC driver was initializing adcp->current_buffer_position and friends only in adc_lld_start(), therefore a simple adcConvert() call did not work when called a second time (only the circular mode worked, because the interrupt handler was resetting the position in that case after the whole buffer was filled). Reset the buffer position variables in adc_lld_start_conversion() to make the one-time conversion work.
RP2040: Init buffer position in adc_lld_start_conversion()
Fixup compilation with gcc12, warnings due to indenting.
Fixed some issues with usb_msd for stm32l496
We need to set the logical HIGH/LOW state here NOT mess with DATA
add missing hooks for GPTD2 fixup the prescaler assert check update the interrupt handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR list: