Added more informative messages during OS check and in the applicatio…

…n log 📧
Sophia-Community · Apr 21, 2022 · 321013b · 321013b
1 parent b5ef8f3
commit 321013b
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 13 deletions.
diff --git a/SophiApp/SophiApp/Helpers/DebugHelper.cs b/SophiApp/SophiApp/Helpers/DebugHelper.cs
@@ -16,6 +16,8 @@ internal class DebugHelper
         private const string APP_THEME = "App theme";
         private const string APP_VER = "App version";
         private const string HAS_INTERNET_ACCESS = "App has access to Internet";
+        private const string LAST_CONDITION = "This is last condition";
+        private const string NEXT_CONDITION = "The next condition to be run:";
         private const string PC_NAME = "Computer name";
         private const string USER_CULTURE = "User culture";
         private const string USER_DOMAIN = "User domain";
@@ -83,7 +85,7 @@ internal static void HasException(string message, Exception e)
             {
                 message,
                 $"Information: {e.Message}",
-                $"The method that caused the error: {e.TargetSite.Name}",
+                $"The method that caused the error: {e.TargetSite.ReflectedType.FullName}",
                 string.Empty
             });
         }
@@ -100,6 +102,8 @@ internal static void HasUpdateRelease(ReleaseDto release) => WriteInfoLog(new Li
 
         internal static void LinkClicked(string link) => WriteStatusLog($"Link clicked: \"{link}\"");
 
+        internal static void NextStartupCondition(string name, bool isLast) => WriteStatusLog(isLast ? LAST_CONDITION : $"{NEXT_CONDITION} {name}");
+
         internal static void RiskAgreed() => WriteStatusLog("USER AGREED TO ASSUME THE RISK AND LIABILITY FOR ANY POSSIBLE DAMAGE");
 
         internal static void Save(string path)
@@ -123,7 +127,7 @@ internal static void Save(string path)
 
         internal static void StartStartupConditions() => WriteStatusLog("The OS conditions checkings started");
 
-        internal static void StartupConditionsInvoked(string name, bool result) => WriteStatusLog($"{name}: {result}");
+        internal static void StartupConditionInvoked(string name, bool result) => WriteStatusLog($"{name} run result: {result}");
 
         internal static void StopApplyingSettings(double totalSeconds) => WriteStatusLog($"Applying setting(s) took {totalSeconds:N0} second(s)");
 

diff --git a/SophiApp/SophiApp/Helpers/StartupConditionsHelper.cs b/SophiApp/SophiApp/Helpers/StartupConditionsHelper.cs
@@ -36,16 +36,18 @@ internal async Task CheckAsync()
         {
             await Task.Run(() =>
             {
-                foreach (var condition in Conditions)
+                for (int i = 0; i < Conditions.Count; i++)
                 {
                     try
                     {
-                        HasProblem = condition.Invoke();
-                        DebugHelper.StartupConditionsInvoked(name: condition.GetType().Name, result: HasProblem.Invert());
+                        var isLastCondition = Conditions.Count - i == 1;
+                        HasProblem = Conditions[i].Invoke();
+                        DebugHelper.StartupConditionInvoked(name: Conditions[i].GetType().Name, result: HasProblem.Invert());
+                        DebugHelper.NextStartupCondition(name: isLastCondition ? Conditions[i].GetType().Name : Conditions[i + 1].GetType().Name, isLast: isLastCondition);
 
                         if (HasProblem)
                         {
-                            ConditionHasProblem?.Invoke(null, condition);
+                            ConditionHasProblem?.Invoke(null, Conditions[i]);
                             break;
                         }
                     }

diff --git a/SophiApp/SophiApp/Localizations/IT.xaml b/SophiApp/SophiApp/Localizations/IT.xaml
@@ -39,12 +39,12 @@
     <system:String x:Key="Localization.ViewApplyingException.InApplying">Mentre si applicavano le modifiche</system:String>
     <system:String x:Key="Localization.ViewApplyingException.HasException">c'è stato un'errore.</system:String>
     <system:String x:Key="Localization.SoftwareDistributionTask.Description">pulendo la cartella %SystemRoot%\SoftwareDistribution\Download.</system:String>
-    <system:String x:Key="Localization.SoftwareDistributionTask.Event"La cache di Windows update è stata eliminata.</system:String>
+    <system:String x:Key="Localization.SoftwareDistributionTask.Event">La cache di Windows update è stata eliminata.</system:String>
     <system:String x:Key="Localization.ClearTempTask.Description">è in corso la pulizia della cartella dei file temporanei.</system:String>
     <system:String x:Key="Localization.ClearTempTask.Event">La cartella dei file temporanei è stata pulita.</system:String>
     <system:String x:Key="Localization.CleanupTask.NotificationTask.Description">Notifiche Pop-up per ricordarti di cancellare i file di Windows inutilizzati e gli aggiornamenti già installati.</system:String>
     <system:String x:Key="Localization.CleanupTask.Description">Cancellazzione dei file temporanei e degli aggiornamenti di Windows già installati con l'app Pulizia disco.</system:String>
-    <system:String x:Key="Localization.CleanupTask.NotificationTask.Title">Informazioni importanti </system:String>
+    <system:String x:Key="Localization.CleanupTask.NotificationTask.Title">Informazioni importanti</system:String>
     <system:String x:Key="Localization.CleanupTask.NotificationTask.EventTitle">Esguire una pulizia dei file temporanei e degli aggiornamenti di Windows già installati?</system:String>
     <system:String x:Key="Localization.CleanupTask.NotificationTask.Event">La pulizia di Windows non richiederà molto. Questa notifica riapparirà fra 30 giorni.</system:String>
     <system:String x:Key="Localization.CleanupTask.NotificationTask.SnoozeInterval">Seleziona fra quanto tempo vuoi che venga rimostrata la notifica</system:String>
@@ -57,10 +57,10 @@
     <system:String x:Key="Localization.About.OfWindows">per Windows&#174;</system:String>
     <system:String x:Key="Localization.Settings.GitHub">GitHub</system:String>
     <system:String x:Key="Localization.Settings.Themes">Temi</system:String>
-    <system:String x:Key="Localization.Settings.Themes.Dark">scuro</system:String>
+    <system:String x:Key="Localization.Settings.Themes.Dark">Scuro</system:String>
     <system:String x:Key="Localization.Settings.Themes.Light">Chiaro</system:String>
     <system:String x:Key="Localization.Settings.Languages">Langua</system:String>
-    <system:String x:Key="Localization.Settings.Advanced">impostazioni avanzate</system:String>
+    <system:String x:Key="Localization.Settings.Advanced">Impostazioni avanzate</system:String>
     <system:String x:Key="Localization.Settings.DebugMode">Modalità sviluppatore</system:String>
     <system:String x:Key="Localization.Settings.Team">Memberi del progetto</system:String>
     <system:String x:Key="Localization.Settings.Leader">Capo del progetto:</system:String>

diff --git a/SophiApp/SophiApp/Resources/UIData.json b/SophiApp/SophiApp/Resources/UIData.json
@@ -4178,4 +4178,4 @@
     "Windows10Supported": true,
     "Windows11Supported": false
   }
-]
+]
diff --git a/SophiApp/SophiApp/SophiApp.csproj b/SophiApp/SophiApp/SophiApp.csproj
@@ -485,6 +485,10 @@
       <Generator>MSBuild:Compile</Generator>
       <SubType>Designer</SubType>
     </Page>
+    <Page Include="Localizations\IT.xaml">
+      <Generator>MSBuild:Compile</Generator>
+      <SubType>Designer</SubType>
+    </Page>
     <Page Include="Localizations\RU.xaml">
       <Generator>MSBuild:Compile</Generator>
       <SubType>Designer</SubType>

diff --git a/SophiApp/SophiApp/ViewModels/Methods.cs b/SophiApp/SophiApp/ViewModels/Methods.cs
@@ -241,8 +241,8 @@ private void InitializeProperties()
         }
 
         private async Task InitializeTextedElements(string tag) => await Task.Run(() => TextedElements.Where(element => element.Tag == tag)
-                                                                                                                                  .ToList()
-                                                                                                                                  .ForEach(element => element.Initialize()));
+                                                                                                                                    .ToList()
+                                                                                                                                    .ForEach(element => element.Initialize()));
 
         private async Task InitializeTextedElementsAsync()
         {