SuppplierOrder #37
Merged
SuppplierOrder #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lierOrdersServiceImpl + SupplierOrdersController +SupplierOrdersView
TudorOrban
reviewed
Mar 25, 2024
src/main/java/org/chainoptim/desktop/features/client/controller/ClientOrdersController.java
Outdated
Show resolved
Hide resolved
| quantityColumn.setCellFactory(TextFieldTableCell.forTableColumn(new FloatStringConverter())); | ||
| statusColumn.setCellFactory(TextFieldTableCell.forTableColumn()); | ||
|
|
||
| tableView.setMaxHeight(Double.MAX_VALUE); |
There was a problem hiding this comment.
You should identify the configuration that can be taken out of here and reused for the other tables we'll have, perhaps through a static method of a util class.
src/main/java/org/chainoptim/desktop/features/client/controller/ClientOrdersController.java
Show resolved
Hide resolved
src/main/java/org/chainoptim/desktop/features/client/controller/ClientOrdersController.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private void setEditEvents() { | ||
| clientIdColumn.setOnEditCommit(event -> { |
There was a problem hiding this comment.
Generialize this setOnEditCommit block to not repeat yourself. But more importantly, do not go to the database for every edited value, there should be a save button somewhere (perhaps restricting to updating one order at a time).
|
|
||
| private void updateInDatabase(ClientOrder order) { |
There was a problem hiding this comment.
Make the update service method and use it here to update. I'll add a Toast system later for confirming successful operation/signaling error.
src/main/java/org/chainoptim/desktop/features/supplier/controller/SupplierOrdersController.java
Outdated
Show resolved
Hide resolved
src/main/resources/org/chainoptim/desktop/features/client/ClientOrdersView.fxml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the table for SupplierOrders. Unlike the table in ClientOrders, I've incorporated a TableView into a StackPane instead of a ScrollPane and haven't noticed any difference; if necessary, StackPane automatically creates its scrollbar. We'll see which option is better once we implement pagination. I still have some minor adjustments to make (for example, fetching the order status).