Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the doc about the onMove return values #1878

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

stof
Copy link
Contributor

@stof stof commented Aug 10, 2020

The doc was missing the case of keeping the default insertion point based on the direction.

closes #1861

The doc was missing the case of keeping the default insertion point based on the direction
Copy link
Contributor

@waynevanson waynevanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thank you :)

@waynevanson waynevanson merged commit 340e8a2 into SortableJS:master Aug 17, 2020
@stof stof deleted the patch-1 branch August 17, 2020 08:14
laukstein pushed a commit to laukstein/Sortable that referenced this pull request Sep 10, 2020
…1878)

The doc was missing the case of keeping the default insertion point based on the direction.
laukstein pushed a commit to laukstein/Sortable that referenced this pull request Sep 10, 2020
…1878)

The doc was missing the case of keeping the default insertion point based on the direction.
owen-m1 added a commit that referenced this pull request Dec 30, 2020
Runi-c pushed a commit to Tupperbox/Sortable that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarifying the signature of the onMove callback
2 participants