Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lua LSP integration support #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

SalHe
Copy link

@SalHe SalHe commented Apr 22, 2023

Hi!
I like Mesen very much. I have added LSP integration in script editor for type annotation and other support. Due to some restriction, I just reimplement the code completion and hove tips in editor. And add code for downloading LSP server automatically(I am not sure whether it's acceptable for you).

Changes mainly for:

  1. Type annotation except getState/setState (they diff from situation and may be unstable, so I just annotate it with table), with type annotation meta file we can code in external editor with code completion and etc.
  2. Mouse hover tips.
  3. Completions on entering (not only for .).
  4. Download LSP Server automatically (Test passed on Windows-x64).

There may be more works to improve the editor experience:

  1. Code format.
  2. Error lens. (I didn't find relative approach to represent error within AvaloniaEdit.TextEditor in place)
  3. Images in completion.
  4. Improve completing
  5. Config for LSP Client.
  6. Whether to embed a LSP server?

Here is a picture for illustrating:
lsp

@SalHe SalHe marked this pull request as ready for review April 22, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant