Fix Visual Effects on tvOS #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound images for the normal and focused state. In addition, clear the background color of all subviews to only have the wanted background image and to fix the "unsharp" border caused by `_UIFloatingContentCornerRadiusAnimatingView`.
… keeping the rounded corners and focus effect (only affects tvOS >= 14). Background and text color are hardcoded for now since they are not included in view data from the backend.
|
Hi @andresilveirah, did you already find some time to take a look? 🙏 |
|
That's fantastic work @asshoffm . Will merge as soon the tests pass and release it at some point this week. Thank you for the PR. |
Nevazhnovu
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
As someone who developed the tvOS SDK, I approve since #LGTM;
I would rather have approval from @andresilveirah on this PR to proceed with merging.
| @@ -317,4 +322,32 @@ class FocusableScrollView: UIScrollView { | |||
| } | |||
| } | |||
|
|
|||
| /// A table view cell with a custom background configuration. | |||
| /// It suppresses unwanted background and border effects that are automatically added by the system | |||
| /// while while keeping the drop shadow and scaling effect when being focused. | |||
There was a problem hiding this comment.
The second while can be safely removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
We now show the GDPR Privacy Manager in our tvOS app 👍🏻
There are two minor UI imperfections that we want to improve with this MR:
SPAppleTVButtonI hope the commit messages and the following screenshots provide enough information for you.