Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on fails WebSocket connection #9

Closed
vsergeenko777 opened this issue Jun 15, 2018 · 3 comments
Closed

Crash on fails WebSocket connection #9

vsergeenko777 opened this issue Jun 15, 2018 · 3 comments

Comments

@vsergeenko777
Copy link

WebSocketClient/JsonWebSocketClient function causes the crash if a connection to WebSocket server was not established. Also, the loss of the established connection causes crash.

[15/06/2018 03:40:36] [debug] Server crashed while executing test.amx
[15/06/2018 03:40:36] [debug] AMX backtrace:
[15/06/2018 03:40:36] [debug] #0 native WebSocketClient () from requests.DLL
[15/06/2018 03:40:36] [debug] #1 0001601c in WebSocketInit () at test.pwn:108
[15/06/2018 03:40:36] [debug] #2 00056aa4 in public OnGameModeInit () at test.pwn:88
[15/06/2018 03:40:37] [debug] Native backtrace:
[15/06/2018 03:40:37] [debug] #0 77ecd97a in ?? () from C:\Windows\SYSTEM32\ntdll.dll
[15/06/2018 03:40:37] [debug] #1 77e9b9b6 in ?? () from C:\Windows\SYSTEM32\ntdll.dll
[15/06/2018 03:40:37] [debug] #2 6e4504db in ?? () from C:\Windows\SYSTEM32\MSVCP140.dll
[15/06/2018 03:40:37] [debug] #3 6baa6b06 in ?? () from plugins\requests.DLL
[15/06/2018 03:40:37] [debug] #4 6baacc61 in ?? () from plugins\requests.DLL
[15/06/2018 03:40:37] [debug] #5 6baa7a96 in ?? () from plugins\requests.DLL
[15/06/2018 03:40:37] [debug] #6 6baad9e8 in ?? () from plugins\requests.DLL
[15/06/2018 03:40:37] [debug] #7 6baa096c in ?? () from plugins\requests.DLL
[15/06/2018 03:40:37] [debug] #8 6bab26be in ?? () from plugins\requests.DLL
[15/06/2018 03:40:37] [debug] #9 004010b6 in ?? () from samp-server-cr.exe
[15/06/2018 03:40:37] [debug] #10 6c1ad60a in ?? () from plugins\crashdetect.DLL

@vsergeenko777 vsergeenko777 changed the title Crash on failed WebSocket connection Crash on fails WebSocket connection Jun 15, 2018
@Southclaws
Copy link
Owner

Thanks, I've added a test case for this and fixed it in 0.6.2.

@vsergeenko777
Copy link
Author

Thanks. There is one more problem. The WebSocketSend function causes crash if the connection to the WebSocket server has been lost. I propose to add the callbacks OnWebSocketConnect/OnWebSocketDisconnect.

@Southclaws Southclaws reopened this Jun 15, 2018
@AGraber
Copy link
Contributor

AGraber commented Oct 6, 2018

fix pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants