-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catching an exception while sending data to ws using JsonWebSocketSend #58
base: master
Are you sure you want to change the base?
catching an exception while sending data to ws using JsonWebSocketSend #58
Conversation
WalkthroughThe recent update enhances the robustness of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/impl.cpp (1 hunks)
Additional comments: 2
src/impl.cpp (2)
- 335-337: The changes to encapsulate the message sending logic within a try block and to log errors in the catch block are good improvements towards enhancing the stability and reliability of the
JsonWebSocketSend
function. This approach effectively addresses the issue of application crashes when the connection is lost during data transmission.- 341-341: While the addition of error logging in the catch block is a significant improvement, consider expanding the exception handling to cover more specific exceptions related to web socket operations. This could provide more granular error information and help in debugging specific issues related to web socket communication.
I'm facing crash while sending data to server when the connection is lost.
Summary by CodeRabbit