-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency kubernetes-sigs/cluster-api to v1.6.0 #661
Conversation
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 11m 27s |
a3ee039
to
ff150f2
Compare
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 25m 02s Warning: Sonobouy results=== Collecting results === time="2023-12-06T10:41:20Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-12-06T10:41:20Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-12-06T10:41:20Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7211 Passed: 5 Failed: 0 Skipped: 7206Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-12-06 10:41:25 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. |
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 24m 37s Warning: Sonobouy results=== Collecting results === time="2023-12-06T11:18:16Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-12-06T11:18:16Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-12-06T11:18:16Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7211 Passed: 5 Failed: 0 Skipped: 7206Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-12-06 11:18:22 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. |
#661 (comment), #661 (comment) ... The problem is with make fullclean task. The problem is in the filtering of instances where we try to filter out control-plane instances(and other related resources) with grep "$CLUSTER-control-plane". In the CAPI v1.6.0 release notes I found kubernetes-sigs/cluster-api#9254 where the naming of the control-plane was changed from |
ff150f2
to
130b331
Compare
Thanks for analyzing the failure @chess-knight! |
130b331
to
558c3db
Compare
Of course we can, we just remove
See my analysis in #495 (comment), as far as I know, the only way, for now, is changing cluster_name itself. |
ecb45e8
to
a12e7d1
Compare
Signed-off-by: SCS Renovate Bot <renovatebot@scs.community>
a12e7d1
to
82a4ebe
Compare
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 24m 03s Warning: Sonobouy results=== Collecting results === time="2024-01-15T11:19:22Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-01-15T11:19:22Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-01-15T11:19:23Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7213 Passed: 5 Failed: 0 Skipped: 7208Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-15 11:19:28 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. |
Ok, I "fixed" fullclean script, and this can be merged IMO, what do you think @garloff?. Still, #495 (comment) holds and needs to be addressed in the future. |
This PR contains the following updates:
1.5.3
->1.6.0
Release Notes
kubernetes-sigs/cluster-api (kubernetes-sigs/cluster-api)
v1.6.0
Compare Source
👌 Kubernetes version support
More information about version support can be found here
Highlights
ipam.cluster.x-k8s.io
have graduated tov1beta1
Deprecation Warning
v1alpha4
is no longer served in this release.v1alpha3
has been completely removed in this release.--metrics-bind-addr
is deprecated for all controllersChanges since v1.5.0
📈 Overview
📝 Proposals
✨ New Features
🐛 Bug Fixes
🌱 Others
SKIP_RESOURCE_CLEANUP
if set in environment (#9152)internal.labels
toformat
package for use by providers (#9002)📖 Additionally, there have been 55 contributions to our documentation and book. (#8260, #8500, #8678, #8819, #8988, #9001, #9013, #9014, #9024, #9029, #9080, #9081, #9087, #9112, #9119, #9141, #9146, #9150, #9161, #9173, #9208, #9209, #9213, #9214, #9232, #9270, #9286, #9291, #9305, #9328, #9364, #9386, #9403, #9415, #9429, #9433, #9463, #9487, #9488, #9490, #9511, #9513, #9514, #9527, #9550, #9559, #9565, #9572, #9577, #9590, #9593, #9613, #9635, #9654, #9706)
Thanks to all our contributors! 😊
v1.5.4
Compare Source
👌 Kubernetes version support
More information about version support can be found here
Changes since v1.5.3
📈 Overview
🐛 Bug Fixes
🌱 Others
📖 Additionally, there has been 1 contribution to our documentation and book. (#9722)
Thanks to all our contributors! 😊
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.