Jwy/integer step #35
Open
Jwy/integer step #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurdala
requested changes
Oct 13, 2023
|
All of them should be fixed atm. (hopefully) |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this part, I look into the integer limitation for the time step. The following are the changes:
neptune.inp
time step change to 2.5 to check if it works out.
rdinp.f90
add double precision function into the file, and make output_step double precision
neptuneClass.f90
move all of the output_step function from integer catagory to double precision catagory
I did some compiling test and it should work. (hopefully)