Add BungeeCord support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kamilkime
requested changes
Feb 3, 2023
bukkit/src/main/java/pl/spaceis/plugin/bukkit/BukkitSpaceIsCommand.java
Outdated
Show resolved
Hide resolved
bukkit/src/main/java/pl/spaceis/plugin/bukkit/BukkitSpaceIsCommand.java
Outdated
Show resolved
Hide resolved
| public interface ConfigLoader { | ||
|
|
||
| void reloadConfig(); | ||
| void reloadConfig() throws ResourceLoaderException; |
There was a problem hiding this comment.
No nie wiem w sumie, czy tak na pewno powinno być, bo ten reload nie musi mieć nic wspólnego z tym resource loaderem
common/src/main/java/pl/spaceis/plugin/resource/ResourceLoader.java
Outdated
Show resolved
Hide resolved
common/src/main/java/pl/spaceis/plugin/resource/ResourceLoaderException.java
Outdated
Show resolved
Hide resolved
common/src/main/java/pl/spaceis/plugin/resource/ResourceLoaderException.java
Show resolved
Hide resolved
Kamilkime
reviewed
Feb 3, 2023
Kamilkime
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.