Improve metagraph locking #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and RAII lock object.
behaviour so that if we don't check the try lock, we actually wait to acquire the mutex (I believe the code was just wrong which might explain some depthmap weirdness in the past)
pklampros
approved these changes
Jan 20, 2018
pklampros
pushed a commit
that referenced
this pull request
Sep 2, 2020
* Replace explicit set/unset of homespun lock with std::recursive_mutex and RAII lock object. * Fix missed locks * Use std::unique_lock rather than hand-rolled helper. Also change the behaviour so that if we don't check the try lock, we actually wait to acquire the mutex (I believe the code was just wrong which might explain some depthmap weirdness in the past) * Replace bool `m_lock_draw` with mutex/unique_lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace explicit set/unset of homespun lock with std::recursive_mutex and RAII lock object.