Open from filesystem macos #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 13, 2018 11:02
… use to load a file
…n pointers to the main window
…e and icon. The graph file icon is provided by Ugo Santana
blsemo
requested changes
Feb 21, 2018
GuiApp/coreapplication.h
Outdated
| settings.writeSetting(SettingTag::licenseAccepted, true); | ||
| } | ||
|
|
||
| if (!settings.readSetting(SettingTag::licenseAccepted, false).toBool()) |
There was a problem hiding this comment.
This looks like a copy & paste error - the license showing code block seems to be duplicated.
GuiApp/coreapplication.h
Outdated
| } | ||
|
|
||
| return QApplication::event(event); | ||
| } | ||
|
|
||
| int exec() { |
There was a problem hiding this comment.
Why does this rather hefty function implementation have to be in the header file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #47 for macOS
Also allows application to be understood as able to view/edit .graph files
Also attaches type name to .graph files ("Graph File") and a relevant icon provided by Ugo Santana