Remove paftl from point.h (and thus replace pqmap with std::map) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blsemo
requested changes
Mar 7, 2018
salaTest/testsparksieve.cpp
Outdated
| // these lines get turned into "blocks" based by a tanify function based on q and the centre given | ||
| // above. Given q=4 and centre 1,1 this line will be from 0.625 to something bigger than 1 | ||
| lines.add(1, Line(Point2f(0.5, 0.2), Point2f(0.5, 0.7))); | ||
| lines.insert(std::make_pair(1, Line(Point2f(0.5, 0.2), Point2f(0.5, 0.7)))); |
There was a problem hiding this comment.
lines[1] = Line(Point2f(0.5, 0.2), Point2f(0.5, 0.7)); is easier to read and achieves the same in this case.
| pt.m_lines.remove_at(k); | ||
| } | ||
| std::map<int, Line>::iterator iter = pt.m_lines.begin(), end = pt.m_lines.end(); | ||
| for(; iter != end; ) { |
There was a problem hiding this comment.
Should probably evaluate .end() in the for statement - depending on the stl implementation, erase might change where end is pointing to.
salalib/pointdata.cpp
Outdated
| pqmap<int,Line> lines0; | ||
| for (size_t m = 0; m < getPoint(curs).m_lines.size(); m++) | ||
| std::map<int,Line> lines0; | ||
| for (std::pair<int,Line> line: getPoint(curs).m_lines) |
There was a problem hiding this comment.
Should be a reference, not a copy of the pair
pklampros
added a commit
that referenced
this pull request
Sep 2, 2020
Remove paftl from point.h (and thus replace pqmap with std::map)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.