-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add port of GLFW backend and use in GLFW example #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
I've reviewed PR and with minor adjustments I would love to merge it. Appreciate your contribution!
Speacking about buffers. I try to keep binding with lower overhead as possible. With avoiding of operations, which do complex things. For example, personally I would prefer to use
instead of
MemoyStack is pretty efficient, but the first variant has the same (or even more) efficiency. Yet it is more straightforward and requeir less operations to do. I don't insist on anything, you can keep your PR in your current variant. Just giving a note. |
That's helpful, thank you. |
…als for data arrays
The original Dear ImGui has an example GLFW backend that shows how we can configure and uself GLFW without having to pollute our application logic with backend specific calls. GLFW is the primary windowing system for LWJGL but I think porting this example is a good addition to the package.