Dev 349 v2

[daroczig]

Summary by CodeRabbit

• New Features

  • Enhanced traffic price calculation with a default direction now set to 'OUT'.
  • Introduced a new endpoint for extracting traffic price filters from free text input.

• Bug Fixes

  • Improved precision in financial calculations by applying consistent rounding logic.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the search_traffic_prices function in src/sc_keeper/api.py, changing the default value of the direction parameter to TrafficDirection.OUT and adding a new rounder helper function for consistent rounding of price calculations. Additionally, the TrafficDirection enumeration is introduced in src/sc_crawler/table_fields.py, aligning with the updated function behavior. A new endpoint for traffic price filters is also added in src/sc_keeper/routers/ai.py, enhancing API functionality.

Changes

Files	Change Summary
src/sc_keeper/api.py	Modified search_traffic_prices to set default direction to TrafficDirection.OUT and added rounder function for consistent rounding of price calculations.
src/sc_crawler/table_fields.py	Added TrafficDirection enumeration.
src/sc_keeper/routers/ai.py	Introduced assist_traffic_price_filters endpoint for extracting traffic price filters from text input.

Assessment against linked issues

Objective	Addressed	Explanation
DRY benchmark references (DEV-349)	❌	No changes related to DB references were made.

🐰 In the code, we hop with glee,
Rounding prices, oh so free!
Traffic flows in a clearer way,
With TrafficDirection, come what may!
Precision's key, we now can see,
A brighter future, just for me! 🌟

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f11d6bf and 73d718a.

Files selected for processing (1)

• src/sc_keeper/routers/ai.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/sc_keeper/routers/ai.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cbd23aa and f11d6bf.

Files selected for processing (3)

• src/sc_keeper/api.py (4 hunks)
• src/sc_keeper/routers/ai.py (1 hunks)
• tests/test_api.py (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/sc_keeper/api.py

Additional context used

Ruff

src/sc_keeper/routers/ai.py

44-44: Redefinition of unused assist_storage_price_filters from line 38

(F811)

GitHub Check: build

src/sc_keeper/routers/ai.py

[failure] 44-44: Ruff (F811)
src/sc_keeper/routers/ai.py:44:5: F811 Redefinition of unused assist_storage_price_filters from line 38

Additional comments not posted (1)

tests/test_api.py (1)

82-82: LGTM!

The code changes are approved.