Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-1565: API docs build failed due to SyntaxError: Unexpected token { #398

Merged
merged 22 commits into from
Jul 20, 2020

Conversation

bkemper
Copy link
Contributor

@bkemper bkemper commented Jul 17, 2020

What has changed?

  • The initial error as documented in the ticket was related to the node version, so bumped from v8 to v10 to resolve that issue.
  • The next build error was TypeError: Cannot read property 'activities' of undefined, so as recommended, bumped gatsby from v2.19 to v2.24 (here is there CHANGELOG) which includes a number of bug fixes, dropping support for node v8, and some interesting features, but nothing breaking for us
  • Upgraded gatsby-plugin-algolia from v0.3.2 to v0.11.1 with only one breaking change that shouldn't affect us, fix(settings): wait for task to finish
  • Upgraded gatsby-plugin-google-tagmanager from v2.1.5 to v2.3.11
  • Upgraded gatsby-plugin-lodash from v3.1.2 to v3.3.10
  • Upgraded gatsby-plugin-netlify from v2.1.3 to v2.3.11
  • Didn't touch gatsby-plugin-netlify-cache
  • Upgraded gatsby-plugin-nprogress from v2.1.2 to v2.3.10
  • Upgraded gatsby-plugin-sharp from v2.0.32 to v2.6.19
  • Upgraded gatsby-plugin-styled-components from v3.1.2 to v3.3.10
  • Upgraded gatsby-remark-images from v3.1.7 to v3.3.19
  • Upgraded gatsby-source-filesystem from v2.2.2 to v2.3.19
  • Upgraded gatsby-source-wordpress from v3.1.14 to v3.3.22 (cough, v3 is deprecated)
  • Upgraded gatsby-transformer-json from v2.2.2 to v2.4.11
  • Upgraded gatsby-transformer-remark from v2.6.11 to v2.8.25
  • Uninstalled the following plugins since they weren't being used
    • gatsby-mdx (also, gatsby has since adopted mdx as a official integration gatsby-plugin-mdx)
    • gatsby-plugin-netlify-cms since it is not being included in gatsby-config.js
    • gatsby-plugin-offline
    • gatsby-plugin-webpack-bundle-analyzer

@bkemper bkemper requested a review from gfriedmansp July 17, 2020 20:50
Copy link
Contributor

@gfriedmansp gfriedmansp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bkemper bkemper merged commit e3ccd9f into master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants