Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename class Resource #150

Closed
zaporylie opened this issue Oct 13, 2016 · 0 comments
Closed

Rename class Resource #150

zaporylie opened this issue Oct 13, 2016 · 0 comments

Comments

@zaporylie
Copy link
Contributor

Word 'resource' is soft reserved in php 7 so we should change name for /Sparkpost/Resource (ref. http://php.net/manual/en/reserved.other-reserved-words.php).

Potential name: ResourceBase
@zaporylie zaporylie mentioned this issue Oct 13, 2016
Merged
ewandennis added a commit that referenced this issue Oct 26, 2016
@ewandennis
Merge pull request #154 from zaporylie/master
bd9440b 
Fix #150: Rename Resource to ResourceBase and leave deprecation note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaporylie