Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to overwrite the default 10 seconds timeout #111

Merged
merged 1 commit into from
May 25, 2016
Merged

Added an option to overwrite the default 10 seconds timeout #111

merged 1 commit into from
May 25, 2016

Conversation

fishr01
Copy link

@fishr01 fishr01 commented May 19, 2016

Added an option to overwrite the default 10 seconds timeout with any value.
Please note I suggest we allow for an entire guzzle configuration to be passed in, as the current method of overwriting the configuration in the Sparkpost class brings confusion as the guzzle configurations that are passed into the wrapper originally are overwritten.

Fixes #106 , #107 , #109

Please note there is an extra parameter that you can now pass into the sparkpost config array that looks like this:

['key' => $config['api-key'], 'timeout' => 0]]

@richleland richleland merged commit 2ce8184 into SparkPost:master May 25, 2016
@richleland
Copy link
Contributor

Thanks for the fix @fishr01!

@zaporylie
Copy link
Contributor

@richleland Can you tag patch release ASAP?

@richleland
Copy link
Contributor

@zaporylie done - 1.2.1

@zaporylie
Copy link
Contributor

Great! Thanks

@chandon
Copy link
Contributor

chandon commented Jun 10, 2016

Is this really the solution ? Why does the Sparkpost api respond so slowly ?

@fishr01 fishr01 deleted the hotfix-timeouts branch June 13, 2016 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants