EOP-281: OpenARC module and APIs #782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dkoerichbird
requested changes
Nov 26, 2024
| it before and what the message's authentication assessment was at each step in the handling flow. | ||
|
|
||
| The openarc module add ARC capability to Momentum. It provides Lua APIs for | ||
| ARC validation on a received email, and ARC siging and sealing on an outgoing email. |
kkelley1
reviewed
Dec 4, 2024
| This function validates the ARC set headers contained in the input message. The validation result | ||
| will be stored as string value (`none` or `pass` or `fail`) in the `ec_message`'s context variable | ||
| of `arc_cv`. A caller can take actions (e.g. disposition of the message) based on the validation | ||
| result. |
There was a problem hiding this comment.
I'm guessing "none" means no ARC headers rather than the status of "cv=none" which is normal for just one ARC header set?
There was a problem hiding this comment.
none means cv=none in ARC-Seal, also means no ARC headers.
There was a problem hiding this comment.
(nit) seems like if a single set of ARC headers checks out, the result should be 'pass', not 'none.
| It guarantees that operations implemented in this hook will happen after the operations done in | ||
| `final_validtion`. | ||
| No any message modification expected after this stage. | ||
| To avoid undefined race between multiple implementations of the same hook, you shall only have up |
There was a problem hiding this comment.
I'd suggest "ordering" rather than "race" and "you should have at most one"
approved
deepakpn
requested changes
Dec 13, 2024
dkoerichbird
approved these changes
Dec 16, 2024
deepakpn
approved these changes
Dec 19, 2024
kkelley1
approved these changes
Jan 3, 2025
deepakpn
requested changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
How To Test or Verify
PR Checklist
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:
All PRs Checklist
team-FEorteam-SAZ)Content Changes Checklist
examples/article.mdin the root of the project directory and on the momentum doc's preface articleDevelopment Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
cypress/directory in the root of the project