-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fonts seem to be broken since 122? #243
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Do you know where the fonts are stored? /var/task/.fonts This should be where fonts are coming from, though the only thing I've done since the old days was add in /var/task/fonts. |
I had this problem too, but after moving the font file from The docker image was using |
@Sparticuz @tsutorm - post-122 I named a folder folder Neither EDIT:
My puppeter.launch args are:
|
+1 , did what @hudsontavares mentioned to nest the font folders inside the Lambda layers and it worked out for me! Thanks for the tip 🙏 |
Thanks 🙏 to both @Sparticuz and all of those who have been providing their working configurations/suggestions it has been of great help. I can add another usage scenario of @hudsontavares's simple change for fonts integrated using a lambda layer worked (#243 (comment)). Hopefully this is helpful to someone else. Changing my lambda layers internal folder naming from .fonts to fonts (i.e. without the '.') allowed me to upversion puppeteer-core, @sparticuz/chromium and the lambda functions runtime to Node20.x. Parameters
|
thx~ |
Environment
chromium
Version: 121playwright-core
Version: 1.42.1nodejs20.x
Expected Behavior
I switched to a lambda layer with a
fonts
directory in it to get NotoColorEmoji working in 119.0.2. Upgrading to 122 should ideally result in the same font loading behavior.Current Behavior
When I tried upgrading to 122, fonts seem to be completely broken. No emojis show up in any of our screenshots, and font rendering for regular text seems to have changed as well (looks like Open Sans isn't even getting loaded?).
Steps to Reproduce
I'm using a lambda layer with the following contents:
No
font
calls in code.Also tried
.fonts
directory and callingfont
in code with the font file packaged inside the lambda directly. No luck.Exact setup worked in 119.0.2, and 121 as well, but not 122.
Also, separate issue, I tried to upgrade to 123 as well, but
context.newPage()
calls in playwright end up timing out, so had to downgrade. Happy to open a separate issue for that if it'd be helpful. Cheers!Possible Solution
Timing-wise, 68f6d48 seems to be a likely culprit. I'm not sure how to inspect the contents of that file to figure out what changed though?
The text was updated successfully, but these errors were encountered: