Added composer.lock to gitignore #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but I would rather change the travis.yml to use the |
|
Ok ok. May I ask what the reason for that is? I don't really see why the lock file would be useful to anyone else. I checked several random other packages to make sure I was doing the right thing and none of them have the lock file committed. |
|
I thought about removing it several times. Maybe it is better since I already test against different versions via travis. If I see any disadvantages in the future, I maybe add it again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly cause I think travis would otherwise test against the possibly outdated composer.lock dependencies, in stead of the composer.json dependencies