support more variable names

SpeakapBV · Aug 7, 2019 · dd9510f · dd9510f
1 parent 9b83b49
commit dd9510f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
   ],
   "license": "MIT",
   "scripts": {
-    "test":  "./node_modules/mocha/bin/mocha test",
+    "test": "./node_modules/mocha/bin/mocha test",
     "debug": "./node_modules/mocha/bin/mocha test --inspect-brk"
   },
   "dependencies": {

diff --git a/src/filtrex.js b/src/filtrex.js
@@ -126,12 +126,11 @@ function filtrexParser() {
                 ['of[^\\w]', 'return "of";'],
 
                 ['\\s+',  ''], // skip whitespace
-                ['[0-9]+(?:\\.[0-9]+)?\\b', 'return "NUMBER";'], // 212.321
-
-                ['[a-zA-Z][\\.a-zA-Z0-9_]*',
+                ['[0-9]+[\\.a-zA-Z_]{2,}',
                  `yytext = JSON.stringify(yytext);
                   return "SYMBOL";`
                 ], // some.Symbol22
+                ['[0-9]+(?:\\.[0-9]+)?\\b', 'return "NUMBER";'], // 212.321
 
                 [`'(?:[^\'])*'`,
                  `yytext = JSON.stringify(
@@ -140,6 +139,11 @@ function filtrexParser() {
                   return "SYMBOL";`
                 ], // 'some-symbol'
 
+                ['[a-zA-Z$_][\\.a-zA-Z0-9_]*',
+                 `yytext = JSON.stringify(yytext);
+                  return "SYMBOL";`
+                ], // some.Symbol22
+
                 ['"(?:\\\\"|[^"])*"', 'return "STRING";'], // "foo"
 
                 // End

diff --git a/test/objects.js b/test/objects.js
@@ -34,4 +34,12 @@ describe('Object support', () => {
         expect(compileExpression('toString of something')({ something: {}})).equals(undefined);
     });
 
+    it('should support more variable names', () => {
+        expect(compileExpression('$.id == "id1"')({ '$.id': "id1"})).equals(1);
+        expect(compileExpression('__id == "id1"')({ '__id': "id1"})).equals(1);
+        expect(compileExpression('0.id == 1337')({ '0.id': 1337})).equals(1);
+        expect(compileExpression('\'0.\' == 1337')({ '0.': 1337})).equals(1);
+        expect(compileExpression('\'0.000id\' == 1337')({ '0.000id': 1337})).equals(1);
+        expect(compileExpression('\'<id>\' == 1337')({ '<id>': 1337})).equals(1);
+    });
 });