fix: patch unit tests, return ntauthstoreproperties to static

SpecterOps · Oct 3, 2023 · bebdd5b · bebdd5b
1 parent 4119c6b
commit bebdd5b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/CommonLib/Processors/LDAPPropertyProcessor.cs b/src/CommonLib/Processors/LDAPPropertyProcessor.cs
@@ -413,7 +413,7 @@ public static Dictionary<string, object> ReadEnrollmentServiceProperties(ISearch
 
             return props;
         }
-        public Dictionary<string, object> ReadNTAuthStoreProperties(ISearchResultEntry entry)
+        public static Dictionary<string, object> ReadNTAuthStoreProperties(ISearchResultEntry entry)
         {
             var ntAuthStoreProps = new NTAuthStoreProperties
             {

diff --git a/test/unit/LDAPPropertyTests.cs b/test/unit/LDAPPropertyTests.cs
@@ -617,9 +617,8 @@ public void LDAPPropertyProcessor_ReadNTAuthStoreProperties()
                     {"whencreated", 1683986131},
                 }, "2F9F3630-F46A-49BF-B186-6629994EBCF9", Label.NTAuthStore);
 
-            var processor = new LDAPPropertyProcessor(new MockLDAPUtils());
-            var props = processor.ReadNTAuthStoreProperties(mock);
-            var keys = props.Keys;
+            var test = LDAPPropertyProcessor.ReadNTAuthStoreProperties(mock);
+            var keys = test.Keys;
 
             Assert.Contains("description", keys);
             Assert.Contains("whencreated", keys);

diff --git a/test/unit/LDAPUtilsTest.cs b/test/unit/LDAPUtilsTest.cs
@@ -104,7 +104,7 @@ public void BuildLdapPath_BadDomain_ReturnsNull()
             Assert.Null(result);
         }
 
-        [Fact]
+        [WindowsOnlyFact]
         public void BuildLdapPath_HappyPath()
         {
             var mock = new Mock<LDAPUtils>();