Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test coverage #74

Merged
merged 3 commits into from
Oct 4, 2023
Merged

chore: improve test coverage #74

merged 3 commits into from
Oct 4, 2023

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Oct 2, 2023

Description

This adds some test coverage around the NTAuthStore properties and the parseAllProperties method.

Motivation and Context

Improving code quality.

How Has This Been Tested?

These tests were run on my mac laptop. I updated some of the test labels to [WindowsOnlyFact] since they were calling windows specific APIs and failed to run on my OS.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@urangel urangel merged commit a7ec97a into adcs Oct 4, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
@urangel urangel deleted the improve-coverage branch October 4, 2023 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants