Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADCS initial MR #76

Merged
merged 96 commits into from
Nov 22, 2023
Merged

ADCS initial MR #76

merged 96 commits into from
Nov 22, 2023

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Oct 4, 2023 •
edited
Loading

Description

Implements support for ADCS collection for ESC1 and parts of ESC3

Motivation and Context

How Has This Been Tested?

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

rvazarkar and others added 30 commits October 5, 2022 14:21
@rvazarkar
wip: begin porting CAA work into v3
27e7e42
@rvazarkar
wip: add PKI ldap properties, dynamically build reserved attribute li…
4a28f2c 
…st for parsing properties, fix naming for cert template/authority objects
@rvazarkar
wip: add some tests, add CertAbuseProcessor with some basic code for …
8c2017c 
…enumerating important things
@rvazarkar
Merge remote-tracking branch 'origin/v3' into adcs
7a980ee 
# Conflicts:
#	src/CommonLib/SharpHoundCommonLib.csproj
@rvazarkar
wip: more cert abuse stuff
43bb2a8
@rvazarkar
Merge remote-tracking branch 'origin/v3' into adcs
d881fc1
@rvazarkar
chore: random fixes
035cc6b
@rvazarkar
Merge remote-tracking branch 'origin/v3' into adcs
dd70362
@rvazarkar
wip: more cert abuse stuff
13143ba
@rvazarkar
Merge remote-tracking branch 'origin/v3' into adcs
b097c8c 
# Conflicts:
#	src/CommonLib/Helpers.cs
@rvazarkar
chore: small updates for ADCS
6e234b0
@rvazarkar @JonasBK
wip: begin porting CAA work into v3
1223db1
@rvazarkar @JonasBK
wip: add PKI ldap properties, dynamically build reserved attribute li…
50c5584 
…st for parsing properties, fix naming for cert template/authority objects
@rvazarkar @JonasBK
wip: add some tests, add CertAbuseProcessor with some basic code for …
52be9e7 
…enumerating important things
@rvazarkar @JonasBK
wip: more cert abuse stuff
fd0ecde
@rvazarkar @JonasBK
chore: random fixes
3ed49d6
@rvazarkar @JonasBK
wip: more cert abuse stuff
58f5218
@rvazarkar @JonasBK
chore: small updates for ADCS
6c7a1e9
@JonasBK
fix: Configuration NC CN correction
d4064c2
@JonasBK
fix: CertAuthority class name correction
bef2040
@JonasBK
add CertTemplate OutputBase
d157efb
@JonasBK
rename cert template LDAP filter
1db23bb
@JonasBK
Add cert objects to ChildObjects for containers
1010185
@JonasBK
improve collection of CA registry data
6224a55
@JonasBK
Add CN=Configuration to CA paths
88971ac
@JonasBK
Add enabled cert templates to CAs
0d9a99b
@JonasBK
Add IsEnterpriseCA and IsRootCA methods
fb881a0
@JonasBK
Add methods to get Configuration and Schema NC paths
71dce61
@JonasBK
fix: Enroll right for cert templates
81bf02c
@JonasBK
Add ApplicationPolicies, IssuancePolicies, and CertificateApplication…
55beec3 
…Policy to cert templates
JonasBK and others added 17 commits October 5, 2023 06:59
@JonasBK
Remove debug console output
869a569
@JonasBK
Fix data arrangement in output
3a3929a
@JonasBK
Add collection of DC reg keys
694c689
@JonasBK
Remove unused output type
ad2c44f
@JonasBK
Merge pull request #78 from BloodHoundAD/dc-reg-keys-and-adcs-refactor
23a541b 
DC reg keys and reorganizing properties in ADCS object's output
@urangel
chore: update output types to lift domain up a level
f9b904f
@urangel
fix: change domain property to domain sid and add domainsid property …
9553455 
…to rootca
@urangel
chore: handle hascrosscertificatepair property during collection inst…
0689b67 
…ead of ingest
@JonasBK
fix: add missing ;
df2abf4
@JonasBK
remove DomainSID from EnterpriseCA
a05c24a
@JonasBK
remove unused duplicate enum
50ec50b
@JonasBK
add NO_SECURITY_EXTENSION flag
b725115
@JonasBK
Add constructed EKU props
a113fe9
@JonasBK
fix AIACA test
be37a92
@JonasBK
Merge branch 'v3' into adcs
82a1cdf
@rvazarkar
Merge branch 'adcs' into eku-props
b0d6491
@rvazarkar
Merge pull request #80 from BloodHoundAD/eku-props
fd82e42 
Add constructed CertTemplate EKU properties
@lawndoc lawndoc mentioned this pull request Oct 24, 2023
Closed
@rvazarkar rvazarkar marked this pull request as ready for review November 16, 2023 20:52
@elikmiller
Copy link
Collaborator

Approving this PR as this version of SH common has undergone extensive manual testing

@elikmiller elikmiller merged commit 6cbc4ed into v3 Nov 22, 2023
3 checks passed
@elikmiller elikmiller deleted the adcs branch November 22, 2023 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elikmiller elikmiller elikmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rvazarkar @elikmiller @JonasBK @urangel @juggernot325