Fixed false positive test for failed attempt checking in authentication

SpectoLabs · Apr 27, 2017 · a2e7751 · a2e7751
1 parent 7ed578b
commit a2e7751
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/authentication/auth_service_test.go b/core/authentication/auth_service_test.go
@@ -26,11 +26,12 @@ func Test_HasReachFailedAttemptsLimit_ReturnsFalseIfAttemptsIsBelowOrEqualToLimi
 	Expect(authentication.HasReachedFailedAttemptsLimit(3, "10s")).To(BeFalse())
 }
 
-func Test_HasReachFailedAttemptsLimit_ReturnsTrueIfAttemptsIsAboveLimit(t *testing.T) {
+func Test_HasReachFailedAttemptsLimit_ReturnsTrueIfAttemptsIsAboveLimit_AndLastFailedIsWithinTheTimeoutPeriod(t *testing.T) {
 	RegisterTestingT(t)
 
 	authentication.Attempts.Count = 4
-	Expect(authentication.HasReachedFailedAttemptsLimit(3, "10s")).To(BeFalse())
+	authentication.Attempts.LastFailed = time.Now()
+	Expect(authentication.HasReachedFailedAttemptsLimit(3, "10s")).To(BeTrue())
 }
 
 func Test_HasReachFailedAttemptsLimit_IncreasesCountIfAttemptsIsAboveLimit_AndLastFailedIsWithinTheTimeoutPeriod(t *testing.T) {