Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS-81: Move project under Speechify's name, setup CI/CD #1

Merged
merged 9 commits into from
Jan 19, 2023
Merged

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Jan 18, 2023

Description

This project was recently moved from the https://github.com/Saghen account. This PR updates package.json and other related places, renames the owner of the repo, and points to @speechify's GitHub packages registry.

Also sets up an automated CI/CD pipeline for testing and deployment.

@linear
Copy link

linear bot commented Jan 18, 2023

AS-81 Fix SSML validation

The following request returns "Invalid SSML"

{
  "audioFormat": "ogg",
  "ssml": " <speak>both P<0.001). The rates of sPGA scores of 0 or 1 at week 12 were also significantly higher with brodalumab 210mg than placebo (79% vs 4% [AMAGINE-2] and 80% vs 4% [AMAGINE-3]; both P<0.001).</speak>", 
  "voiceParams": {
    "name": "A",
    "engine": "google",
    "languageCode":"en-GB"
  }
}

However, the SSML looks valid. At the first glance, it seems that < cause the validation to fail.

Copy link
Contributor

@Saghen Saghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things:

  • Can we use .yaml for the workflows for consistency with our manifests in other projects
  • Publish to @saghen/string-tracker on NPM as well. I've added a token for writing packages as NPM_TOKEN

.nvmrc Outdated Show resolved Hide resolved
@GedasGa GedasGa requested a review from Saghen January 18, 2023 19:52
@Saghen Saghen merged commit bba81de into main Jan 19, 2023
@Saghen Saghen deleted the AS-81 branch January 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants