Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: SDK-38 AuthorizationServerMetadata support #162

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

sanderPostma
Copy link
Contributor

@sanderPostma sanderPostma commented Oct 22, 2024

No description provided.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 102 lines in your changes missing coverage. Please review.

Project coverage is 48.21%. Comparing base (0603b43) to head (10e7492).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
.../lib/builder/AuthorizationServerMetadataBuilder.ts 21.60% 98 Missing ⚠️
packages/issuer/lib/VcIssuer.ts 33.33% 2 Missing ⚠️
packages/issuer/lib/builder/VcIssuerBuilder.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #162      +/-   ##
===========================================
- Coverage    48.81%   48.21%   -0.60%     
===========================================
  Files           74       75       +1     
  Lines         5005     5144     +139     
  Branches      1787     1791       +4     
===========================================
+ Hits          2443     2480      +37     
- Misses        2560     2662     +102     
  Partials         2        2              
Flag Coverage Δ
unittest 48.21% <29.16%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanderPostma sanderPostma marked this pull request as ready for review October 24, 2024 10:01
zoemaas
zoemaas previously approved these changes Oct 31, 2024
Copy link
Contributor

@zoemaas zoemaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoemaas zoemaas dismissed their stale review October 31, 2024 13:05

Failing test

@zoemaas
Copy link
Contributor

zoemaas commented Oct 31, 2024

The code in general LGTM however there is a failing test, please fix it

@sanderPostma sanderPostma merged commit 5e12677 into develop Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants