Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mso mdoc handling #165

Merged

Conversation

TimoGlastra
Copy link
Collaborator

allows handling of mdoc presentations using integration with pex.

What it does:

  • parse/evluate vp token / definitions with mdoc (and other formats combined, tests for this in pex repo)
  • select credentials for pd with mdoc (and other formats combined, tests for this in pex repo)

What it doesn't do:

  • extract and verify the nonce from the mdoc presentation. We can enable this when the device respnose parsing is mixed in mdl lib. However as the nonce is part of verifying the session transcript it's not really an issue
  • allow creating a VP with mdoc. In the test i bypass this. We need the device response stuff for this and some better typing. It's mostly focused on the verifier role for now

Needs Sphereon-Opensource/PEX#184 to be released and add for tests to succeed.

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (86f6d4a) to head (403debf).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #165   +/-   ##
========================================
  Coverage    49.11%   49.11%           
========================================
  Files           74       74           
  Lines         4976     4976           
  Branches      1769     1731   -38     
========================================
  Hits          2444     2444           
  Misses        2529     2529           
  Partials         3        3           
Flag Coverage Δ
unittest 49.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sanderPostma sanderPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanderPostma sanderPostma merged commit 3b516be into Sphereon-Opensource:develop Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants