Dcql #171
Dcql #171
Conversation
packages/siop-oid4vp/lib/authorization-response/AuthorizationResponse.ts
Outdated
Show resolved
Hide resolved
packages/siop-oid4vp/lib/authorization-response/AuthorizationResponse.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Very nice, left some nits. I think the main thing is the comment about linking the submission to the query entries. But maybe it's just hard to see and that happens in the dcql library (as long as it's easy to do this matching for the end user).
Also because vp_token is a mapping from query id to VP, I assume every vp will only contain one credential?
packages/siop-oid4vp/lib/authorization-response/AuthorizationResponse.ts
Outdated
Show resolved
Hide resolved
packages/siop-oid4vp/lib/authorization-response/AuthorizationResponse.ts
Outdated
Show resolved
Hide resolved
packages/siop-oid4vp/lib/authorization-response/AuthorizationResponse.ts
Outdated
Show resolved
Hide resolved
|
Hey @nklomp just checking whether you think you can merge / release this already before the funke deadline? Otherwise we'll create a fork now. |
Signed-off-by: Timo Glastra <timo@animo.id>
| } | ||
|
|
||
| return { | ||
| ...(opts.id_token ? { id_token: opts.id_token } : {}), | ||
| ...((opts.vp_token.presentation_definition || opts.vp_token.presentation_definition_uri) && { | ||
| ...((opts.vp_token.presentation_definition || opts.vp_token.presentation_definition_uri || opts.vp_token.dcql_query) && { | ||
| vp_token: { | ||
| ...(!opts.vp_token.presentation_definition_uri && { presentation_definition: opts.vp_token.presentation_definition }), |
There was a problem hiding this comment.
This line needs to be adjusted, as the definition_uri would not be present with a dcql_query. Suggest to move the opts.vc_token.dclq_query expression to a signle line, so it makes a clear distinction between either a PD or PD URI (current logic) and a dcql_query
| @@ -139,6 +144,14 @@ export class AuthorizationResponse { | |||
| hasher: verifyOpts.hasher, | |||
| }, | |||
| }) | |||
| } else { | |||
There was a problem hiding this comment.
Rather would have seen an else if, with the below throw in an else. Right now the if expression is asymmetric. In the end it really checks for 3 states, but the if else is only 2 states with then an additional check in the else
Add experimental DCQL query language support
Initial implementation of DCQL (Digital Credential Query Language.
Status
initial tests have verified the basic functionality. More testing is required to ensure that everything works correctly.