fix: Make sure we do not use the jwk thumbprint as kid default value …

…when not in EBSI
Sphereon-Opensource · Jul 7, 2024 · c4a22aa · c4a22aa
1 parent 9a3bf56
commit c4a22aa
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/oid4vci-holder/src/agent/OID4VCIHolderService.ts b/packages/oid4vci-holder/src/agent/OID4VCIHolderService.ts
@@ -276,7 +276,13 @@ export const getIdentifierOpts = async (args: GetIdentifierArgs): Promise<Identi
     }
   }
   const key: _ExtendedIKey = await getAuthenticationKey(identifier, context, identifier.did.startsWith('did:ebsi'), true)
-  const kid: string = (identifier.did.startsWith('did:ebsi:') ? key.meta?.jwkThumbprint : key.meta.verificationMethod?.id) ?? key.kid
+  let kid: string = key.meta.verificationMethod?.id ?? key.kid
+  if (identifier.did.startsWith('did:ebsi:')) {
+    kid = key.meta?.jwkThumbprint
+  } else if (!kid.startsWith('did:')) {
+    const optionalHashTag = kid.startsWith('#') ? '' : '#'
+    kid = `${identifier.did}${optionalHashTag}${kid}`
+  }
 
   return { identifier, key, kid }
 }