Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compilation of templates in ./custom/brand/tpl/**/*.html #328

Merged
merged 1 commit into from
Sep 24, 2013

Conversation

devgeeks
Copy link
Collaborator

This allows templates compiled from there to overwrite templates compiled from ./tpl/*/.html

Also found and corrected contact email branding and an issue that had caused some parts of the about view to not show even on the mail released app.

This allows templates compiled from there to overwrite templates compiled from ./tpl/**/*.html

Also found and corrected contact email branding and an issue that had caused some parts of the about view to not show even on the mail released app.
@devgeeks devgeeks mentioned this pull request Sep 24, 2013
@kenmanheimer
Copy link
Contributor

This is useful, and I will commit it. I have a small issue with it worth mentioning - it may deserve eventual attention, but isn't clearly a problem:

  • unlike the other customization provisions, this happens in-place, while the other customization stuff only happens in device builds. For one thing, this means that tests and javascript-only compositions of the app (so, eg, it can be run in the desktop browser) will include the custom templates, but not the other custom stuff.

I don't see that this will cause problems, but might result in surprises for those (probably rare few) among that use the browser composition to test things, but is worth mentioning because it may have unexpected ramifications.

kenmanheimer added a commit that referenced this pull request Sep 24, 2013
Added compilation of templates in ./custom/brand/tpl/**/*.html
@kenmanheimer kenmanheimer merged commit 4726d86 into master Sep 24, 2013
@kenmanheimer kenmanheimer deleted the brand-templates branch September 24, 2013 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants