Issue 374 - favorites migration and fixes #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold off on this. I am having trouble proving it works. |
|
This should be good to test now. Email incoming with testing instructions. |
kenmanheimer
added a commit
that referenced
this pull request
Dec 12, 2013
…and-fixes Issue 374 - favorites migration and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374
Also fixes up a couple of longstanding but elusive bugs relating to refreshing favourites and multiply binding the
refreshAllbutton.The migration fixes up the url and icon, then if the user ever does a refresh of that fave it also fixes the path as it downloads the new version to the new path.