Add Custom Toast Title #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added custom (optional) title for toast, this is needed for situations where localization is used.
Spikeysanju
requested changes
Oct 25, 2020
| @@ -151,7 +152,7 @@ class MotionToast { | |||
| successToastColor | |||
| ) | |||
| ) | |||
| layout.custom_toast_text.text = TOAST_SUCCESS | |||
| layout.custom_toast_text.text = if(title == null) TOAST_SUCCESS else title | |||
There was a problem hiding this comment.
Hey @NotNotMarshall, Thanks for making a PR. It looks good to me. It will be better if we use this approach.
Instead of checking title == null, we can use the extension function title.isNullOrBlank()
Sample code:
layout.custom_toast_text.text = if(title.isNullOrBlank()) TOAST_SUCCESS else title
Reason for this approach 👇
title = " " // title with blank space
println(data.isNullOrBlank()?.toString()) //true
println(data.isNullOrEmpty()?.toString()) //false
Can you please make a change in all states like this?
There was a problem hiding this comment.
Done mate! ^_^
changed title == null check to title.isNullOrBlank()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom (optional) title for toast, this is needed for situations where localization is used.