Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added enum constant for toast style selection #32

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

k10tetry
Copy link

A better approach to choose toast styles from pre-defined enum style constants, also now the developers can not pass any random string value which falls in else case

Copy link
Owner

@Spikeysanju Spikeysanju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Spikeysanju Spikeysanju merged commit e817857 into Spikeysanju:master Oct 12, 2021
@Spikeysanju
Copy link
Owner

PR merged thanks for brining up this 🙌

@k10tetry
Copy link
Author

Great! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants