Fix Dokka documentation for Kotlin+Java projects #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripolkaandrey
force-pushed
the
fix-dokka-multilanguage
branch
from
68af3e7
to
31bd35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR which extended our Dokka support did not fully cover all edge-cases of generating documentation. One was found during generating documentation for a multi-language project with both Java and Kotlin source files. Currently, Dokka does not allow a clear and concise way to generate documentation for both Java+Kotlin projects. You are either "seeing Java code as Kotlin" or vice versa. Now we are sticking to generating documentation for Java code. This PR is fixing the described issue by considering only Java source files when generating Dokka documentation via
dokka-for-javascript plugin. Also, this PR bumpsspine-dokka-extensions.